-
Notifications
You must be signed in to change notification settings - Fork 713
fix: add cancel function to the Timer API to make it behave correctly with finalizers and selectables
#10630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
algebraic-dev
merged 9 commits into
leanprover:master
from
algebraic-dev:sofia/timer-fix
Oct 8, 2025
Merged
fix: add cancel function to the Timer API to make it behave correctly with finalizers and selectables
#10630
algebraic-dev
merged 9 commits into
leanprover:master
from
algebraic-dev:sofia/timer-fix
Oct 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancel function to the Timer API to make it behave correctly with finalizers and selectables.cancel function to the Timer API to make it behave correctly with finalizers and selectables.
cancel function to the Timer API to make it behave correctly with finalizers and selectables.cancel function to the Timer API to make it behave correctly with finalizers and selectables
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
TwoFX
reviewed
Oct 1, 2025
Member
TwoFX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clearly needs tests!
TwoFX
approved these changes
Oct 6, 2025
hargoniX
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the Timer API selector to make it finish as soon as possible when unregistered. This change makes the
Selectable.onefunction drop theselectablesarray as soon as possible, so when combined with finalizers that have some effects like the TCP socket finalizer, it runs it as soon as possible.