Skip to content

fix: expose Int* definitions for simprocs and decide (fixes #10546) #10631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
datokrat merged 8 commits into from
Oct 1, 2025
Merged

fix: expose Int* definitions for simprocs and decide (fixes #10546) #10631

datokrat merged 8 commits into from
Oct 1, 2025

Conversation

@datokrat
Copy link
Contributor

@datokrat datokrat commented Oct 1, 2025 •
edited
Loading

This PR exposes the definitions about Int*. The main reason is that the SInt simprocs require many of them to be exposed. Furthermore, decide now works with Int* operations. This fixes #10631.

@datokrat datokrat added the changelog-library Library label Oct 1, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-09-30 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-01 12:38:57)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10631
371eed7
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10631
4436eb2
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 1, 2025

Mathlib CI status (docs):

@datokrat datokrat marked this pull request as ready for review October 1, 2025 13:38
@datokrat datokrat requested a review from kim-em as a code owner October 1, 2025 13:38
@datokrat datokrat added this pull request to the merge queue Oct 1, 2025
Merged via the queue into master with commit 1efefc2 Oct 1, 2025
23 checks passed
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@datokrat @arthur-adjedj
fix: expose Int* definitions for simprocs and decide (fixes leanp…
12b35fc 
…rover#10546) (leanprover#10631)

This PR exposes the definitions about `Int*`. The main reason is that
the `SInt` simprocs require many of them to be exposed. Furthermore,
`decide` now works with `Int*` operations. This fixes leanprover#10631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@datokrat @leanprover-bot @leanprover-community-bot @TwoFX