Skip to content

chore: docstring review for ByteArray #10632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
david-christiansen merged 1 commit into from
Oct 2, 2025
Merged

chore: docstring review for ByteArray #10632

david-christiansen merged 1 commit into from
Oct 2, 2025

Conversation

@david-christiansen
Copy link
Contributor

@david-christiansen david-christiansen commented Oct 1, 2025

This PR adds missing docstrings for ByteArray and makes existing ones consistent with our style.

@david-christiansen
chore: docstring review for ByteArray
8d0bf2f 
This PR adds missing docstrings for ByteArray and makes existing ones
consistent with our style.
@david-christiansen david-christiansen added the changelog-doc Documentation label Oct 1, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-01 13:15:37)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10632
8dc03e1
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10632
55e3ed2
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 1, 2025

Mathlib CI status (docs):

@david-christiansen david-christiansen added this pull request to the merge queue Oct 2, 2025
Merged via the queue into leanprover:master with commit 0b2193c Oct 2, 2025
39 of 41 checks passed
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@david-christiansen @arthur-adjedj
chore: docstring review for ByteArray (leanprover#10632)
b7b8da5 
This PR adds missing docstrings for ByteArray and makes existing ones
consistent with our style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-doc Documentation toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@david-christiansen @leanprover-bot @leanprover-community-bot