refactor: incorporate UTF8 material from String.Extra into String.Basic #10634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthur-adjedj
pushed a commit
to arthur-adjedj/lean4
that referenced
this pull request
Oct 6, 2025
…ic (leanprover#10634) This PR defines `ByteArray.validateUTF8`, uses it to show that `ByteArray.IsValidUtf8` is decidable and redefines `String.fromUTF8` and friends to use it. The functions `String.validateUTF8` and `String.utf8DecodeChar?` are deprecated in favor of the identically named functions in the `ByteArray` namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines
ByteArray.validateUTF8, uses it to show thatByteArray.IsValidUtf8is decidable and redefinesString.fromUTF8and friends to use it.The functions
String.validateUTF8andString.utf8DecodeChar?are deprecated in favor of the identically named functions in theByteArraynamespace.