Skip to content

fix: hygiene for goals generated by mvcgen #10639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgraf812 merged 1 commit into from
Oct 1, 2025
Merged

fix: hygiene for goals generated by mvcgen #10639

sgraf812 merged 1 commit into from
Oct 1, 2025

Conversation

@sgraf812
Copy link
Contributor

@sgraf812 sgraf812 commented Oct 1, 2025

This PR fixes hygiene of the local context for all goals generated by mvcgen, not just those that get a fresh MVar as in #9781.

@sgraf812 sgraf812 added the changelog-language Language features and metaprograms label Oct 1, 2025
@sgraf812 sgraf812 enabled auto-merge October 1, 2025 13:58
@sgraf812 sgraf812 added this pull request to the merge queue Oct 1, 2025
auto-merge was automatically disabled October 1, 2025 14:43

Pull Request is not mergeable

Merged via the queue into master with commit 3095c9d Oct 1, 2025
19 checks passed
@sgraf812 sgraf812 deleted the sg/hygiene branch October 1, 2025 15:02
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 1, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase dfd3d185300df044fa087d3fa166cb6fb3bd8269 --onto d88e417cda0f7afb1e15c806c6bfdbbb09ba7eef. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-01 15:09:05)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase dfd3d185300df044fa087d3fa166cb6fb3bd8269 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-01 15:09:07)

arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@sgraf812 @arthur-adjedj
fix: hygiene for goals generated by mvcgen (leanprover#10639)
516d683 
This PR fixes hygiene of the local context for *all* goals generated by
`mvcgen`, not just those that get a fresh MVar as in leanprover#9781.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sgraf812 @leanprover-community-bot @leanprover-bot