Skip to content

chore: missing docstring + style updates for String docs #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
david-christiansen merged 1 commit into from
Oct 2, 2025
Merged

chore: missing docstring + style updates for String docs #10640

david-christiansen merged 1 commit into from
Oct 2, 2025

Conversation

@david-christiansen
Copy link
Contributor

@david-christiansen david-christiansen commented Oct 1, 2025

This PR adds a missing docstring and applies our style guide to parts of the String API.

@david-christiansen
chore: missing docstring + style updates for String docs
00230c3 
This PR adds a missing docstring and applies our style guide to parts
of the String API.
@david-christiansen david-christiansen added the changelog-doc Documentation label Oct 1, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 1, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9dc1faf3270b6646b1df36f1a590ac3b848a2c05 --onto d88e417cda0f7afb1e15c806c6bfdbbb09ba7eef. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-01 15:13:48)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 9dc1faf3270b6646b1df36f1a590ac3b848a2c05 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-01 15:13:50)

@david-christiansen david-christiansen added this pull request to the merge queue Oct 2, 2025
Merged via the queue into leanprover:master with commit 2c6576b Oct 2, 2025
21 checks passed
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@david-christiansen @arthur-adjedj
chore: missing docstring + style updates for String docs (leanprover#…
0b4f666 
…10640)

This PR adds a missing docstring and applies our style guide to parts of
the String API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

changelog-doc Documentation toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@david-christiansen @leanprover-community-bot @leanprover-bot @TwoFX