Skip to content

fix: consider underscores in getHexNumSize #10719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kha merged 1 commit into from
Oct 16, 2025
Merged

fix: consider underscores in getHexNumSize #10719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Init/Meta/Defs.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,10 +1210,16 @@ def getHexNumVal (s : Syntax.HexNum) : Nat :=
isHexNum? s.raw |>.getD 0

/-- Returns the number of hexadecimal digits. -/
def getHexNumSize (s : Syntax.HexNum) : Nat :=
partial def getHexNumSize (s : Syntax.HexNum) : Nat :=
match Syntax.isLit? hexnumKind s.raw with
| some val => val.utf8ByteSize
| some val => go val 0 0
| _ => 0
where
go (s : String) (p : String.Pos.Raw) (n : Nat) : Nat :=
if String.Internal.atEnd s p then
n
else
go s (String.Internal.next s p) (if String.Internal.get s p = '_' then n else n + 1)

/--
Extracts the parsed name from the syntax of an identifier.
Expand Down
4 changes: 4 additions & 0 deletions tests/lean/run/hexnum.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,7 @@ macro_rules
/-- info: (3, 10) : Nat × Nat -/
#guard_msgs in
#check #00a

/-- info: (8, 65536) : Nat × Nat -/
#guard_msgs in
#check #0001_0000
Loading