Skip to content

Conversation

@linesthatinterlace
Copy link
Contributor

@linesthatinterlace linesthatinterlace commented Oct 11, 2025

This PR renames theorems that use sorted in their name to instead use pairwise.

Closes #10742.

@linesthatinterlace linesthatinterlace marked this pull request as draft October 11, 2025 12:48
@linesthatinterlace
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Oct 11, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 11, 2025

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-10-11 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-11 13:43:10)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase fb3e2c15fd8d50f5d97fcd1ea98899e83bdc3250 --onto efbbb0b230ce95653d25b59c83fd24a51a8bf363. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-23 12:33:44)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 11, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-11 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-11 13:43:12)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase fb3e2c15fd8d50f5d97fcd1ea98899e83bdc3250 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-23 12:33:45)

Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add deprecations?

@TwoFX TwoFX added awaiting-author Waiting for PR author to address issues and removed awaiting-review Waiting for someone to review the PR labels Oct 14, 2025
@linesthatinterlace linesthatinterlace marked this pull request as ready for review October 23, 2025 09:09
@linesthatinterlace
Copy link
Contributor Author

@TwoFX I don't seem to be able to remove the "awaiting author" label but I have added the deprecations.

@TwoFX TwoFX self-assigned this Oct 23, 2025
@TwoFX TwoFX added awaiting-review Waiting for someone to review the PR and removed awaiting-author Waiting for PR author to address issues labels Oct 23, 2025
@TwoFX TwoFX added the changelog-library Library label Oct 23, 2025
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TwoFX TwoFX enabled auto-merge October 30, 2025 15:59
@TwoFX TwoFX added this pull request to the merge queue Oct 30, 2025
Merged via the queue into leanprover:master with commit 275f907 Oct 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review Waiting for someone to review the PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misnamed "sorted" theorems

4 participants