Skip to content

fix: detect private references in inferred type of public def #10762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kha merged 7 commits into from
Oct 15, 2025
Merged

fix: detect private references in inferred type of public def #10762

Kha merged 7 commits into from
Oct 15, 2025

Conversation

@Kha
Copy link
Member

@Kha Kha commented Oct 13, 2025

This PR fixes an inconsistency in the module system around defs with elided types.

@Kha Kha added the changelog-no Do not include this PR in the release changelog label Oct 13, 2025
@Kha Kha force-pushed the push-npzqvlwuoqzr branch from 46a922f to 39609ff Compare October 14, 2025 15:29
@Kha Kha enabled auto-merge October 14, 2025 15:31
@Kha Kha requested a review from tydeu as a code owner October 14, 2025 15:33
@Kha Kha added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 14, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 14, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-13 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-14 16:35:49)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10762
3d3d567
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10762
282337c
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 14, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 14, 2025 •
edited
Loading

Mathlib CI status (docs):

@tydeu tydeu removed their request for review October 15, 2025 02:05
@Kha Kha enabled auto-merge October 15, 2025 12:42
@Kha Kha added this pull request to the merge queue Oct 15, 2025
Merged via the queue into leanprover:master with commit c474775 Oct 15, 2025
14 checks passed
@Kha Kha deleted the push-npzqvlwuoqzr branch October 15, 2025 13:59
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kha @leanprover-bot @leanprover-community-bot