Skip to content

feat: Iterator find? consumer and variants #10769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
datokrat merged 4 commits into from
Oct 20, 2025
Merged

feat: Iterator find? consumer and variants #10769

datokrat merged 4 commits into from
Oct 20, 2025

Conversation

@datokrat
Copy link
Contributor

@datokrat datokrat commented Oct 14, 2025

This PR adds a find? consumer in analogy to List.find? and variants thereof.

@datokrat datokrat added the changelog-library Library label Oct 14, 2025
@datokrat datokrat changed the base branch from master to paul/base/iterators/find October 14, 2025 10:49
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 14, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 14, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-12 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-14 10:51:54)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 7a47bfa2084eec2ec6dbc292d703e6297c2ccee8 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-14 16:02:35)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 746206c5e6b5157aaf8548d4bca72bd1eb474bc8 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-15 08:11:48)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10769
ebaa1b6
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10769
12b233c
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 14, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 14, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-10769 has successfully built against this PR. (2025-10-14 11:55:28) View Log
  • ✅ Mathlib branch lean-pr-testing-10769 has successfully built against this PR. (2025-10-14 13:44:18) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 7a47bfa2084eec2ec6dbc292d703e6297c2ccee8 --onto 14ff08db6f651775ead432d367b6b083878bb0f9. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-14 16:02:34)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 746206c5e6b5157aaf8548d4bca72bd1eb474bc8 --onto 14ff08db6f651775ead432d367b6b083878bb0f9. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-15 08:11:46)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10769
b41966a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 14, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10769
9fa8639
@datokrat datokrat force-pushed the paul/iterators/find branch from 8f9e0d4 to d16a395 Compare October 14, 2025 15:08
@datokrat datokrat force-pushed the paul/base/iterators/find branch from f5b053d to 0579ebd Compare October 14, 2025 15:08
@datokrat datokrat marked this pull request as ready for review October 14, 2025 15:14
@datokrat datokrat requested a review from kim-em as a code owner October 14, 2025 15:14
@datokrat datokrat force-pushed the paul/base/iterators/find branch from 0579ebd to 746206c Compare October 15, 2025 07:19
@datokrat datokrat force-pushed the paul/iterators/find branch from d16a395 to 65315a6 Compare October 15, 2025 07:19
@datokrat datokrat changed the base branch from paul/base/iterators/find to master October 15, 2025 15:02
@datokrat datokrat requested a review from TwoFX October 15, 2025 15:03
@datokrat datokrat added this pull request to the merge queue Oct 20, 2025
Merged via the queue into master with commit 71f1a6c Oct 20, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@TwoFX TwoFX Awaiting requested review from TwoFX

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@datokrat @leanprover-bot @leanprover-community-bot