feat: add DTreeMap/TreeMap/TreeSet iterators and slices #10776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datokrat
reviewed
Oct 16, 2025
wkrozowski
changed the title
TwoFX
reviewed
Oct 31, 2025
src/Std/Data/DTreeMap/Iterator.lean
Outdated
| Raw.valuesIter cmp ⟨m.inner⟩ | ||
|
|
||
| @[simp] | ||
| public theorem iter_toList {cmp : α → α → Ordering} (m : DTreeMap α β cmp) : |
Member
There was a problem hiding this comment.
Unresolving because the name is still not correct.
wkrozowski
added
changelog-library
wkrozowski
changed the title
wkrozowski
changed the title
TwoFX
reviewed
Nov 10, 2025
src/Std/Data/DTreeMap/Raw/Slice.lean
Outdated
| letI _ : Ord α := ⟨cmp⟩; ⟨fun carrier range => ⟨carrier.inner, range⟩⟩ | ||
|
|
||
| public theorem toList_ric {α : Type u} {β : α → Type v} (cmp : α → α → Ordering := by exact compare) | ||
| [TransCmp cmp] {t : Raw α β cmp} {wf : t.WF} {bound : α} : |
Member
There was a problem hiding this comment.
I think the wf argument should be explicit, otherwise it seems to me that the theorem would be needlessly difficult to apply.
| public import Std.Data.TreeMap.Basic | ||
|
|
||
| /-! | ||
| This module provides slice notation for `TreeMap` slices and implements an iterator |
Member
There was a problem hiding this comment.
At the moment the situation is this:
example : t[1<...<3].toList = t.toList.filter (fun p => compare p.1 1 = .gt && compare p.1 3 = .lt) := by
simp -- this works
example : t[1<...<3].iter.toList = t.toList.filter (fun p => compare p.1 1 = .gt && compare p.1 3 = .lt) := by
simp -- this fails at the momentThis is slightly regrettable, but it seems that the solution here would be to make the reverse of Std.Slice.toList_eq_toList_iter into a simp lemma which is independent of this PR. I will discuss with Paul.
TwoFX
approved these changes
Nov 11, 2025
Member
TwoFX
left a comment
TwoFX
left a comment
There was a problem hiding this comment.
One tiny typo, otherwise this looks ready to merge!
Thanks!
Co-authored-by: Markus Himmel <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
This PR adds iterators and slices for `DTreeMap`/`TreeMap`/`TreeSet` based on zippers and provides basic lemmas about them. --------- Co-authored-by: Markus Himmel <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds iterators and slices for
DTreeMap/TreeMap/TreeSetbased on zippers and provides basic lemmas about them.