Skip to content

fix: preserve error locations when expanding match arms #10783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nomeata merged 5 commits into from
Oct 15, 2025
Merged

fix: preserve error locations when expanding match arms #10783

nomeata merged 5 commits into from
Oct 15, 2025

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 15, 2025

This PR ensures that error messages such as “redundant alternative” have
the right error location even if the arms share their RHS. Fixes #10781.

@nomeata
fix: preserve error locations when expanding match arms
92981df 
This PR ensures that error messages such as “redundant alternative” have
the right error location even if the arms share their RHS. Fixes #10781.
@nomeata
Revert "fix: preserve error locations when expanding match arms"
639476f 
This reverts commit 92981df.
@nomeata
This at least works, though probably not the way to do it
43f448f
@nomeata nomeata added the changelog-language Language features and metaprograms label Oct 15, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 15, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 15, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-13 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-15 10:02:12)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 15, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10783
f0c38e2
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 15, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10783
8835096
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 15, 2025 •
edited
Loading

Mathlib CI status (docs):

@nomeata nomeata mentioned this pull request Oct 15, 2025
Closed
@nomeata nomeata marked this pull request as ready for review October 15, 2025 13:28
@nomeata nomeata enabled auto-merge October 15, 2025 13:29
@nomeata nomeata added this pull request to the merge queue Oct 15, 2025
Merged via the queue into master with commit 8431088 Oct 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

redundant alternative error has wrong location when patterns share their RHS

4 participants

@nomeata @leanprover-bot @leanprover-community-bot