Skip to content

fix: only run processInaccessibleAsCtor if there is at least one constructor around #10793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nomeata merged 3 commits into from
Oct 16, 2025
Merged

fix: only run processInaccessibleAsCtor if there is at least one constructor around #10793

nomeata merged 3 commits into from
Oct 16, 2025

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 15, 2025

This PR fixes #10792.

@nomeata nomeata added the changelog-language Language features and metaprograms label Oct 15, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 15, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 15, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-13 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-15 16:53:44)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 15, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10793
d8aadbd
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 15, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10793
b50f17a
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 15, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 15, 2025

Mathlib CI status (docs):

@nomeata nomeata marked this pull request as ready for review October 16, 2025 08:20
@nomeata nomeata added this pull request to the merge queue Oct 16, 2025
Merged via the queue into master with commit 8748031 Oct 16, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

match compilation: inefficient inaccessible pattern checking

4 participants

@nomeata @leanprover-bot @leanprover-community-bot