Skip to content

fix: more pedantic checking of inaccessible patterns #10796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nomeata merged 10 commits into from
Oct 17, 2025
Merged

fix: more pedantic checking of inaccessible patterns #10796

nomeata merged 10 commits into from
Oct 17, 2025

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 15, 2025 •
edited
Loading

This PR changes match compilation to reject some pattern matches that were previously accepted due to inaccessible patterns sometimes treated like accessible ones. Fixes #10794.

@nomeata nomeata added the changelog-language Language features and metaprograms label Oct 15, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 15, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 15, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 114f7e42f1abd10885e91698cd2910b1e4d76083 --onto 14ff08db6f651775ead432d367b6b083878bb0f9. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-15 17:32:41)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 15, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 114f7e42f1abd10885e91698cd2910b1e4d76083 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-15 17:32:43)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-17 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-17 16:01:39)

@nomeata nomeata added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Oct 17, 2025
@nomeata nomeata marked this pull request as ready for review October 17, 2025 15:01
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 17, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10796
95b7ce7
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 17, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10796
69b0ce7
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Oct 17, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 17, 2025

@nomeata nomeata added this pull request to the merge queue Oct 17, 2025
Merged via the queue into master with commit c221000 Oct 17, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

match compilation: inaccessible pattern can case match arm to be skipped

4 participants

@nomeata @leanprover-community-bot @leanprover-bot