chore: more module system fixes and refinements for finishing batteries port #10819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
added
the
fast-ci
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Kha
requested review from
digama0,
hargoniX,
kmill and
leodemoura
as code owners
Kha
removed
the
fast-ci
eric-wieser
reviewed
Oct 19, 2025
| let blocked := (← get).diag.unfoldAxiomCounter.toList.filterMap fun (n, count) => do | ||
| let count := count - origDiag.unfoldAxiomCounter.findD n 0 | ||
| guard <| count > 0 && getOriginalConstKind? env n matches some .defn | ||
| return m!"{.ofConstName n} ↦ {count}" |
Contributor
There was a problem hiding this comment.
This use of ↦ is a little confusing given it looks like fun f ↦ 1.
Member
Author
There was a problem hiding this comment.
This style was established by diagnostics, though I'm open to discussion whether the number of occurrences is actually helpful here. @kmill I recall you had some opinion here.
Comment on lines
+39
to
+42
| Note: The following definitions were not unfolded because their definition is not exposed: | ||
| f ↦ 1 | ||
| ⊢ f = 1 |
Contributor
There was a problem hiding this comment.
This is a little confusing; these two 1s are unrelated, right? Can you change one of them to 2 or 37?
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 20, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Oct 20, 2025
leanprover-community-bot
added
the
builds-mathlib
Kha
added a commit
that referenced
this pull request
Oct 21, 2025
…es port (#10873) Backport 37b78bd from #10819. Co-authored-by: Sebastian Ullrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.