feat: split and splitInclusive iterators are finite
#10820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows that the iterators returned by
String.Slice.splitandString.Slice.splitInclusiveare finite as long as the forward matcher iterator for the pattern is finite (which we already know for all of our patterns).At actually also completely redefines the iterators to avoid the inner loop in
Internal.nextMatchwhich generates inefficient code. Instead, when encountering a mismach from the matcher, weskipthe split iterator.