Skip to content

fix: deprecation warning location with field notation #10826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nomeata merged 7 commits into from
Oct 23, 2025
Merged

fix: deprecation warning location with field notation #10826

nomeata merged 7 commits into from
Oct 23, 2025

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 17, 2025

This PR fixes the location of the “deprecated constant” and similar error messages on field notation (e.f, (e).f, e |>. f). Fixes #10821.

@nomeata nomeata added the changelog-language Language features and metaprograms label Oct 17, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 17, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 17, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f9adafe54d5070acbd270643f71b8455ca8c8d68 --onto 4ce7ad19cea348506876685a19a7e0cca442c6d0. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-17 16:52:45)
  • 💥 Mathlib branch lean-pr-testing-10826 build failed against this PR. (2025-10-21 12:10:26) View Log
  • ✅ Mathlib branch lean-pr-testing-10826 has successfully built against this PR. (2025-10-23 17:40:54) View Log

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 17, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase f9adafe54d5070acbd270643f71b8455ca8c8d68 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-17 16:52:47)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-20 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-21 11:14:23)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10826
1a742f5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10826
09155dc
@leanprover-community-bot leanprover-community-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 21, 2025
@nomeata nomeata added this pull request to the merge queue Oct 23, 2025
Merged via the queue into master with commit 74fd468 Oct 23, 2025
30 checks passed
wkrozowski pushed a commit to wkrozowski/lean4 that referenced this pull request Oct 27, 2025
@nomeata @wkrozowski
fix: deprecation warning location with field notation (leanprover#10826)
fae0909 
This PR fixes the location of the “deprecated constant” and similar
error messages on field notation (`e.f`, `(e).f`, `e |>. f`). Fixes
leanprover#10821.
kim-em pushed a commit that referenced this pull request Oct 27, 2025
@nomeata @kim-em
fix: deprecation warning location with field notation (#10826)
743d015 
This PR fixes the location of the “deprecated constant” and similar
error messages on field notation (`e.f`, `(e).f`, `e |>. f`). Fixes
#10821.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecation warning shown in the wrong place with |>.

4 participants

@nomeata @leanprover-community-bot @leanprover-bot