feat: generate instantiate only [...] at finish?
#10841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
grindtactic generated by theinstantiateaction in tracing mode. It also updates the syntax for theinstantiatetactic, making it similar tosimp. For example:instantiate only [thm1, thm2]instantiates only theoremsthm1andthm2.instantiate [thm1, thm2]instantiates theorems marked with the@[grind]attribute and theoremsthm1andthm2.The action produces
instantiate only [...]tactics. Example:Recall that
finish?replays generated tactics before suggesting them.The
instantiateaction inspects the generated proof term to decide which theorems to include as parameters in theinstantiate only [...]tactic. However, in some cases, a theorem contributes only by adding a term to the state. In such cases, the generated tactic cannot be fully replayed, and the action usesinstantiate approx [<thms instantiated>]to indicate which parts of the tactic script are approximate. Theapproxis just a hint for users.