Skip to content

chore: rename String.endPos -> String.rawEndPos #10853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TwoFX merged 3 commits into from
Oct 21, 2025
Merged

chore: rename String.endPos -> String.rawEndPos #10853

TwoFX merged 3 commits into from
Oct 21, 2025

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Oct 20, 2025

This PR renames String.endPos to String.rawEndPos, as in a future release the name String.endPos will be taken by the function that is currently called String.endValidPos.

@TwoFX TwoFX added the changelog-library Library label Oct 20, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 21, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 21, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-20 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-21 07:19:38)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10853
dcc0dae
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 21, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10853
1b94b4c
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 21, 2025 •
edited
Loading

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 21, 2025
@TwoFX TwoFX marked this pull request as ready for review October 21, 2025 11:25
@TwoFX TwoFX enabled auto-merge October 21, 2025 11:25
@TwoFX TwoFX added this pull request to the merge queue Oct 21, 2025
Merged via the queue into leanprover:master with commit b28daa6 Oct 21, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@mhuisi mhuisi Awaiting requested review from mhuisi mhuisi is a code owner

@kmill kmill Awaiting requested review from kmill kmill is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@Kha Kha Awaiting requested review from Kha Kha is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TwoFX @leanprover-bot @leanprover-community-bot