Skip to content

Conversation

@wkrozowski
Copy link
Contributor

@wkrozowski wkrozowski commented Oct 22, 2025

This PR adds union operations on DTreeMap/TreeMap/TreeSet and their raw variants and provides lemmas about union operations.

@wkrozowski wkrozowski changed the title feat: add union on TreeMaps (WIP) feat: add union on DTreeMap/TreeMap/TreeSet Oct 24, 2025
@wkrozowski wkrozowski marked this pull request as ready for review October 24, 2025 10:23
@wkrozowski wkrozowski requested a review from TwoFX as a code owner October 24, 2025 10:23
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 24, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 24, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 69d8d63d58e56e873654341d4dddaac2c4a70737 --onto efbbb0b230ce95653d25b59c83fd24a51a8bf363. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-24 11:01:39)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 69d8d63d58e56e873654341d4dddaac2c4a70737 --onto 705084d9ba258dec704af428d7ce2444525f9ffb. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-30 23:49:06)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 69d8d63d58e56e873654341d4dddaac2c4a70737 --onto 3e86729ee0e11548a47f9b294d5292ada92c0b40. You can force Mathlib CI using the force-mathlib-ci label. (2025-11-03 13:44:29)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 69d8d63d58e56e873654341d4dddaac2c4a70737 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-24 11:01:41)

wkrozowski and others added 14 commits October 30, 2025 21:52
@wkrozowski
Copy link
Contributor Author

@datokrat Thanks for your comments! I have responded to and fixed everything :)

Copy link
Contributor

@datokrat datokrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if you address the naming of union_insert lemmas!

@wkrozowski wkrozowski added this pull request to the merge queue Nov 3, 2025
Merged via the queue into leanprover:master with commit 00e2907 Nov 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants