-
Notifications
You must be signed in to change notification settings - Fork 715
feat: symbol frequency extension #10918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
!bench |
|
Benchmark results for 6f9ffa1 against 3ce7d4e are in! @kim-em |
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Collaborator
|
Here are the benchmark results for commit 6f9ffa1. Benchmark Metric Change
====================================================================
- Init size bytes .olean 1.3%
+ channel.lean boundedn_seq -7.4%
+ riscv-ast.lean branch-misses -1.6% (-429.9 σ)
- stdlib blocked 3.0% (20.2 σ)
- stdlib size bytes .olean 1.2%
+ workspaceSymbols with new ranges branches -2.2% (-122.6 σ)
+ workspaceSymbols with new ranges instructions -3.0% (-124.7 σ) |
de7431c to
e9acfd4
Compare
e9acfd4 to
7ac2793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-language
Language features and metaprograms
changes-stage0
Contains stage0 changes, merge manually using rebase
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an environment extension for tracking the frequency of symbols in declaration signatures.
On the export of each module, we scan the new constants' types and generate a frequency map just for that module.
When the extension is imported, we do nothing.
When the extension is queried, we assemble the frequency maps for all imported modules into a single
NameMap Nat, and cache that in anIO.Ref.