perf: inline decidable instances #10934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-no
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Contributor
|
!radar |
|
Benchmark results for f1fe306 against 5957364 are in! @hargoniX Minor changes (1)
|
Contributor
|
I would assume the channel regression is likely noise given that the benchmark is not necessarily deterministic and there is no other significant change. |
wkrozowski
pushed a commit
to wkrozowski/lean4
that referenced
this pull request
Oct 27, 2025
This PR adds inline annotations to several `Decidable` instances. Additionally, it removes the `Decidable` instance for `p → q` which is made redundant by `forall_prop_decidable`.
kim-em
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Oct 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
This PR reverts #10934
3 tasks
Rob23oba
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Oct 29, 2025
This reverts commit f512a44.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
This PR inlines several Decidable instances for performance reasons. Unlike the previous #10934 it does not attempt to also simplify the Decidable instance system as that has proven to have non trivial performance impact. Co-authored-by: Rob23oba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds inline annotations to several
Decidableinstances. Additionally, it removes theDecidableinstance forp → qwhich is made redundant byforall_prop_decidable.