Skip to content

Conversation

@linesthatinterlace
Copy link
Contributor

@linesthatinterlace linesthatinterlace commented Oct 24, 2025

This PR removes a redundant instance requirement from Std.instIrreflLtOfIsPreorderOfLawfulOrderLT.

@linesthatinterlace linesthatinterlace marked this pull request as draft October 24, 2025 12:53
@linesthatinterlace linesthatinterlace changed the title fix: Remove redundant instance requirement from Std.instIrreflLtOfIsPreorderOfLawfulOrderLT. fix: Remove redundant instance requirement Oct 24, 2025
@linesthatinterlace
Copy link
Contributor Author

I haven't submitted a bug for this - I can do if it seems necessary but it is such a small change I am hoping that won't be necessary.

@datokrat
Copy link
Contributor

datokrat commented Oct 24, 2025

No, no need for a bug ticket, this is sufficient. Not sure what broke in "Linux Lake"; perhaps retriggering will help?

@TwoFX
Copy link
Member

TwoFX commented Oct 24, 2025

This is due to #10922 landing, so -Werror is now enabled on all PRs. Merging master should help.

@linesthatinterlace linesthatinterlace marked this pull request as ready for review October 24, 2025 15:25
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 24, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e71d0abc7ddb2c9da37e91b88fd2be2a903601c7 --onto efbbb0b230ce95653d25b59c83fd24a51a8bf363. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-24 16:13:27)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase e71d0abc7ddb2c9da37e91b88fd2be2a903601c7 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-24 16:13:28)

@linesthatinterlace
Copy link
Contributor Author

I can't add the changelog label myself.

@TwoFX
Copy link
Member

TwoFX commented Oct 24, 2025

Try commenting changelog-library.

@linesthatinterlace
Copy link
Contributor Author

changelog-library

@github-actions github-actions bot added the changelog-library Library label Oct 25, 2025
@datokrat
Copy link
Contributor

Thanks, good catch!

@datokrat datokrat self-assigned this Oct 27, 2025
@datokrat datokrat added this pull request to the merge queue Oct 30, 2025
Merged via the queue into leanprover:master with commit e11ef3e Oct 30, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants