-
Notifications
You must be signed in to change notification settings - Fork 713
feat: add union on ExtDHashMap/ExtHashMap/ExtHashSet #10946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add union on ExtDHashMap/ExtHashMap/ExtHashSet #10946
Conversation
1cf8380 to
7887726
Compare
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
TwoFX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more request: in DHashMap/Basic.lean, in the docstring for union, there is a typo: it should say contained instead of contains. Would you mind quickly fixing that as part of this PR.
The PR looks good modulo some minor comments, feel free to merge after fixing.
This PR adds union operation on ExtDHashMap/ExtHashMap/ExtHashSet nd provides lemmas about union operations. Stacked on top of #10946.
This PR adds union operation on ExtDHashMap/ExtHashMap/ExtHashSet nd provides lemmas about union operations.