Skip to content

chore: add deprecations for duplicated theorems #10967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kim-em merged 4 commits into from
Oct 29, 2025
Merged

chore: add deprecations for duplicated theorems #10967

kim-em merged 4 commits into from
Oct 29, 2025

Conversation

@kim-em
Copy link
Collaborator

@kim-em kim-em commented Oct 26, 2025

No description provided.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 26, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 26, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-25 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-26 10:36:09)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-27 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-28 01:42:19)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 26, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10967
e1c08fd
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 26, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10967
8d21653
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 26, 2025

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 26, 2025
Rob23oba
Rob23oba reviewed Oct 26, 2025
View reviewed changes
@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Oct 26, 2025
@kim-em kim-em force-pushed the deprecated_duplicated branch from b0952e3 to 9b2c843 Compare October 27, 2025 06:36
@kim-em kim-em force-pushed the deprecated_duplicated branch from 9b2c843 to 905c960 Compare October 28, 2025 00:44
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10967
16cdffe
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10967
bb09da0
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2025

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10967
cd4d5e7
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10967
3bc7c66
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2025

kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 29, 2025
@kim-em
more deprecations for leanprover/lean4#10967
9b48b5b
@leanprover-community-bot leanprover-community-bot removed awaiting-mathlib We should not merge this until we have a successful Mathlib build breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 29, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 29, 2025

@kim-em kim-em added this pull request to the merge queue Oct 29, 2025
Merged via the queue into master with commit 335e34d Oct 29, 2025
27 of 28 checks passed
@nomeata nomeata mentioned this pull request Oct 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datokrat datokrat Awaiting requested review from datokrat datokrat is a code owner

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@TwoFX TwoFX Awaiting requested review from TwoFX TwoFX is a code owner

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

1 more reviewer

@Rob23oba Rob23oba Rob23oba left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kim-em @leanprover-bot @leanprover-community-bot @Rob23oba