fix: search for empty string #10985
Merged
fix: search for empty string #10985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwoFX
added a commit
to TwoFX/lean4
that referenced
this pull request
Oct 29, 2025
This PR ensures that searching for an empty string returns the expected pattern of alternating size-zero matches and size-one rejects. In particular, splitting by an empty string returns an array formed of the empty string, all of the string's characters as singleton strings, followed by another empty string. This matches the [Rust behavior](https://doc.rust-lang.org/std/primitive.str.html#method.split), for example.
TwoFX
added a commit
to TwoFX/lean4
that referenced
this pull request
Oct 29, 2025
This PR ensures that searching for an empty string returns the expected pattern of alternating size-zero matches and size-one rejects. In particular, splitting by an empty string returns an array formed of the empty string, all of the string's characters as singleton strings, followed by another empty string. This matches the [Rust behavior](https://doc.rust-lang.org/std/primitive.str.html#method.split), for example.
TwoFX
added a commit
to TwoFX/lean4
that referenced
this pull request
Oct 29, 2025
This PR ensures that searching for an empty string returns the expected pattern of alternating size-zero matches and size-one rejects. In particular, splitting by an empty string returns an array formed of the empty string, all of the string's characters as singleton strings, followed by another empty string. This matches the [Rust behavior](https://doc.rust-lang.org/std/primitive.str.html#method.split), for example.
TwoFX
added a commit
that referenced
this pull request
Oct 29, 2025
This PR ensures that searching for an empty string returns the expected pattern of alternating size-zero matches and size-one rejects. In particular, splitting by an empty string returns an array formed of the empty string, all of the string's characters as singleton strings, followed by another empty string. This matches the [Rust behavior](https://doc.rust-lang.org/std/primitive.str.html#method.split), for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that searching for an empty string returns the expected pattern of alternating size-zero matches and size-one rejects.
In particular, splitting by an empty string returns an array formed of the empty string, all of the string's characters as singleton strings, followed by another empty string. This matches the Rust behavior, for example.