Skip to content

fix: KMP implementation #10998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TwoFX merged 3 commits into from
Oct 29, 2025
Merged

fix: KMP implementation #10998

TwoFX merged 3 commits into from
Oct 29, 2025

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Oct 28, 2025

This PR fixes the KMP implementation, which did incorrect bookkeeping of the backtracking process, leading to incorrect starting ranges of matches.

The new implementation does not require partial anywhere.

@TwoFX TwoFX added the changelog-no Do not include this PR in the release changelog label Oct 28, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 28, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 28, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 19533ab1d4312903f98ff0429a5962db24ce402b --onto 3a42ee0c3060e2a8365927d205ead5990366053d. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-28 18:39:36)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 28, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 19533ab1d4312903f98ff0429a5962db24ce402b --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-28 18:39:37)

@TwoFX TwoFX marked this pull request as ready for review October 29, 2025 05:58
@TwoFX TwoFX requested a review from kim-em as a code owner October 29, 2025 05:58
@TwoFX TwoFX enabled auto-merge October 29, 2025 05:58
@TwoFX TwoFX added this pull request to the merge queue Oct 29, 2025
Merged via the queue into leanprover:master with commit 106b0fa Oct 29, 2025
15 checks passed
TwoFX added a commit to TwoFX/lean4 that referenced this pull request Oct 29, 2025
@TwoFX
fix: KMP implementation (leanprover#10998)
9ade2b6 
This PR fixes the KMP implementation, which did incorrect bookkeeping of
the backtracking process, leading to incorrect starting ranges of
matches.

The new implementation does not require `partial` anywhere.
TwoFX added a commit to TwoFX/lean4 that referenced this pull request Oct 29, 2025
@TwoFX
fix: KMP implementation (leanprover#10998)
60e3087 
This PR fixes the KMP implementation, which did incorrect bookkeeping of
the backtracking process, leading to incorrect starting ranges of
matches.

The new implementation does not require `partial` anywhere.
TwoFX added a commit to TwoFX/lean4 that referenced this pull request Oct 29, 2025
@TwoFX
fix: KMP implementation (leanprover#10998)
80d2a1a 
This PR fixes the KMP implementation, which did incorrect bookkeeping of
the backtracking process, leading to incorrect starting ranges of
matches.

The new implementation does not require `partial` anywhere.
TwoFX added a commit that referenced this pull request Oct 29, 2025
@TwoFX
fix: KMP implementation (#10998)
ba0f86d 
This PR fixes the KMP implementation, which did incorrect bookkeeping of
the backtracking process, leading to incorrect starting ranges of
matches.

The new implementation does not require `partial` anywhere.
@nomeata nomeata mentioned this pull request Oct 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TwoFX @leanprover-community-bot @leanprover-bot