-
Notifications
You must be signed in to change notification settings - Fork 715
perf: improve join point finding #10999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!radar |
|
Benchmark results for 3f1522d against 19533ab are in! @hargoniX |
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
3f1522d to
4442762
Compare
|
!radar |
|
Benchmark results for 4442762 against a51822e are in! @hargoniX Minor changes (1)
|
|
!radar |
|
Benchmark results for 02bcc41 against a51822e are in! @hargoniX Minor changes (3)
|
|
!radar |
|
Benchmark results for 79e0306 against a51822e are in! @hargoniX Minor changes (3)
|
|
!radar |
|
Benchmark results for db7cda4 against a51822e are in! @hargoniX Minor changes (1)
|
|
!bench |
|
Benchmark results for 5a0b63a against a51822e are in! @hargoniX Minor changes (3)
|
5a0b63a to
b8bd409
Compare
|
!radar |
|
Benchmark results for b8bd409 against a51822e are in! @hargoniX Runs (1)
Minor changes (1)
|
|
Here are the benchmark results for commit 5a0b63a. Benchmark Metric Change
==================================================
+ channel.lean unbounded_seq -2.7%
- iterators (elab) instructions 1.1% (29.1 σ) |
b8bd409 to
c31beeb
Compare
|
!radar |
|
Benchmark results for c31beeb against a51822e are in! @hargoniX Minor changes (1)
|
This PR improves join point finding in the compiler through two means:
fcan only become a join point when a functiongbecomes a join point as well correctly.
simplification pass, as the specialiser might have introduced new join point opportunities for
the simplifier to exploit.
Notably in the code from #10995 we now correctly detect the missing join point which required both
of these changes to be made.
Closes: #10995