fix: revert the waitAny refactoring #11000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memleak caused by the Lean based
IO.waitAnyimplementation by reverting it.This the faulty Lean implementation:
In a situation where we call this function repeatedly in a loop with a pair of tasks
[t1, t2]where
t2is a long lived task that we pass every time andt1is fresh a short lived task,t2willaccumlate more and more children from
BaseIO.chainTaskthat fill memory over time. The old C++implementation did not have this issue so we are reverting.