Skip to content

chore: deprecate more duplications #11004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kim-em merged 7 commits into from
Oct 30, 2025
Merged

chore: deprecate more duplications #11004

kim-em merged 7 commits into from
Oct 30, 2025

Conversation

@kim-em
Copy link
Collaborator

@kim-em kim-em commented Oct 29, 2025

This PR deprecates various duplicated definitions, detected in #mathlib4 > duplicate declarations @ 💬

@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Oct 29, 2025
@kim-em kim-em force-pushed the deprecate_duplicates_2 branch from 4cc11f6 to a2e7245 Compare October 29, 2025 11:52
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 29, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-29 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-29 12:38:30)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11004
fe346e8
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11004
eedd474
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 29, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 29, 2025

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11004
3dfee4a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11004
a0cae37
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 30, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11004
da7ab6c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 30, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11004
eb32513
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

kim-em added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 30, 2025
@kim-em
fixes for leanprover/lean4#11004
360792a
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 30, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025

@kim-em kim-em added this pull request to the merge queue Oct 30, 2025
Merged via the queue into master with commit 705084d Oct 30, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@TwoFX TwoFX Awaiting requested review from TwoFX TwoFX is a code owner

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kim-em @leanprover-bot @leanprover-community-bot