Skip to content

fix: more stable eager lambda lifting heuristic #11010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hargoniX merged 1 commit into from
Oct 29, 2025
Merged

fix: more stable eager lambda lifting heuristic #11010

hargoniX merged 1 commit into from
Oct 29, 2025

Conversation

@hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Oct 29, 2025

This PR makes the eager lambda lifting heuristic more predictable by blocking it from lifting from
any kind of inlineable function, not just @[inline]. It also adapts the doc-string to describe
what is actually going on.

@hargoniX hargoniX requested a review from leodemoura as a code owner October 29, 2025 09:55
@hargoniX hargoniX added the changelog-compiler Compiler, runtime, and FFI label Oct 29, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 29, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2cfd9805285a35b60e61eaf5ce199fc752877f37 --onto 19533ab1d4312903f98ff0429a5962db24ce402b. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-29 10:50:14)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 2cfd9805285a35b60e61eaf5ce199fc752877f37 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-29 10:50:16)

@hargoniX
Copy link
Contributor Author

hargoniX commented Oct 29, 2025

!radar

@leanprover-radar
Copy link

leanprover-radar commented Oct 29, 2025 •
edited
Loading

Benchmark results for d8370d4 against 2cfd980 are in! @hargoniX

@hargoniX hargoniX added this pull request to the merge queue Oct 29, 2025
Merged via the queue into master with commit 1587d02 Oct 29, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees

No one assigned

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hargoniX @leanprover-community-bot @leanprover-bot @leanprover-radar