Skip to content

refactor: use String.ofList and String.toList for String <-> List Char conversion #11017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TwoFX merged 3 commits into from
Oct 31, 2025
Merged

refactor: use String.ofList and String.toList for String <-> List Char conversion #11017

TwoFX merged 3 commits into from
Oct 31, 2025

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Oct 30, 2025

This PR establishes String.ofList and String.toList as the preferred method for converting between strings and lists of characters and deprecates the alternatives String.mk, List.asString and String.data.

@TwoFX TwoFX added the changelog-library Library label Oct 30, 2025
@TwoFX TwoFX changed the title refactor: use String.ofList and String.toList for String <-> List Char conversion. refactor: use String.ofList and String.toList for String <-> List Char conversion Oct 30, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 30, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 30, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b2b385b45678532b7f269a92d76912c2dedc7ed7 --onto 106b0fa661d96fd1fa6ff96e2ee5f55f23f307f2. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-30 10:07:22)
  • 🟡 Mathlib branch lean-pr-testing-11017 build against this PR was cancelled. (2025-10-31 13:36:42) View Log
  • 💥 Mathlib branch lean-pr-testing-11017 build failed against this PR. (2025-10-31 14:28:38) View Log

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 30, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase b2b385b45678532b7f269a92d76912c2dedc7ed7 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-30 10:07:23)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-31 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-31 12:46:05)

@TwoFX TwoFX mentioned this pull request Oct 30, 2025
Merged
@TwoFX TwoFX force-pushed the markus/string-list-rename-2 branch from 8af91b3 to f7baee0 Compare October 31, 2025 11:42
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 31, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11017
540ebba
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 31, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11017
0841694
@TwoFX TwoFX marked this pull request as ready for review October 31, 2025 13:35
@TwoFX TwoFX enabled auto-merge October 31, 2025 13:35
@TwoFX TwoFX added this pull request to the merge queue Oct 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2025
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 31, 2025
@TwoFX TwoFX enabled auto-merge October 31, 2025 14:31
@TwoFX TwoFX added this pull request to the merge queue Oct 31, 2025
Merged via the queue into leanprover:master with commit 377f149 Oct 31, 2025
14 checks passed
@TwoFX TwoFX mentioned this pull request Nov 1, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 1, 2025
@TwoFX
chore: use String.ofList instead of String.mk in elaborator+kernel (
cf871a8 
#11048)

This PR is a follow-up to #11017, preparing for the eventual removal of
the `String.mk` function.
@nomeata nomeata mentioned this pull request Nov 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees

No one assigned

Labels

breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-library Library force-mathlib-ci toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TwoFX @leanprover-community-bot @leanprover-bot