-
Notifications
You must be signed in to change notification settings - Fork 715
feat: List slices
#11019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: List slices
#11019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 30, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Oct 30, 2025
Collaborator
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 31, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Oct 31, 2025
Rob23oba
reviewed
Oct 31, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 11, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Nov 11, 2025
Contributor
Author
|
!radar |
|
Benchmark results for 7cba2da against ed73cdd are in! @datokrat Runs (1)
Major changes (1)
Minor changes (3)
|
Rob23oba
reviewed
Nov 11, 2025
TwoFX
reviewed
Nov 12, 2025
ed73cdd to
2b85e29
Compare
7cba2da to
10bb408
Compare
Contributor
Author
|
!radar |
|
Benchmark results for 10bb408 against 2b85e29 are in! @datokrat Runs (1)
Major changes (1)
Minor changes (3)
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 13, 2025
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Nov 13, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Nov 13, 2025
20dc6d3 to
ac54c21
Compare
Contributor
Author
|
!radar |
|
Benchmark results for ac54c21 against de07370 are in! @datokrat Minor changes (7)
|
Contributor
Author
|
!radar |
|
Benchmark results for ac54c21 against de07370 are in! @datokrat Minor changes (7)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-manual
This is not necessarily a blocker for merging, but there needs to be a plan.
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces slices of lists that are available via slice notation (e.g.,
xs[1...5]).takecombinator and theListiterator producer toInit.toTakecombinator:it.toTakebehaves likeit, but it has the same type asit.take n. There is a constant cost per iteration compared toititself.Listslices. Their iterators are defined assuffixList.iter.take nfor upper-bounded slices andsuffixList.iter.toTakefor unbounded ones.Performance characteristics of using the slice
list[a...b]:O(a)O(1)toList:O(b - a + 1)(given that a <= b)Because the slice only stores a suffix of
xsinternally, two slices can be equal even though the underlying lists differ in an irrelevant prefix. Because thestopfield is allowed to be beyond the list's upper bound, the slices[1][0...1]and[1][0...2]are not equal, even though they effectively cover the same range of the same list. Improving this would require us to callList.lengthwhen building the slice, which would iterate through the whole list.