Skip to content

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Oct 31, 2025

This PR updates the pr-title CI check to enforce that the commit message does not start with a capital letter followed by a non-capital letter.

This should ensure that messages do not start with a capitalized word, but allow messages that start with an acronym.

@TwoFX TwoFX requested a review from kim-em as a code owner October 31, 2025 06:33
@TwoFX TwoFX added the changelog-no Do not include this PR in the release changelog label Oct 31, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 31, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1ce05b2a179eac8a902995c0caddc609c0169c49 --onto 705084d9ba258dec704af428d7ce2444525f9ffb. You can force Mathlib CI using the force-mathlib-ci label. (2025-10-31 07:21:19)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 1ce05b2a179eac8a902995c0caddc609c0169c49 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-10-31 07:21:21)

@TwoFX TwoFX added this pull request to the merge queue Oct 31, 2025
Merged via the queue into leanprover:master with commit c41cb64 Oct 31, 2025
22 checks passed
@nomeata
Copy link
Collaborator

nomeata commented Oct 31, 2025

So feat: FunInd: don't crash would be disallowed now?

@nomeata
Copy link
Collaborator

nomeata commented Oct 31, 2025

I guess I'll just put In in front of component names

@TwoFX
Copy link
Member Author

TwoFX commented Oct 31, 2025

@nomeata Yes, I agree that this is unfortunate, I apologize for that. We could have a label to go back to the old rule on individual PRs. Would you use that?

@nomeata
Copy link
Collaborator

nomeata commented Oct 31, 2025

No, that's clearly overkill. I'll adapt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants