fix: overeager uint constant folding #11042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hargoniX
force-pushed
the
hbv/fix_uint_const_fold
branch
from
bf4cee5 to
3544d4d
Compare
hargoniX
added
changelog-compiler
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2025
This PR fixes a case of overeager constant folding on Nat where the compiler would mistakenly assume `0 - x = x` (see also #11042 for the same bug on UInts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a case of overeager constant folding on UInts where the compiler would mistakenly
assume
0 - x = x.