Skip to content

fix: lake: use -O0 for debug builds #11062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tydeu merged 3 commits into from
Nov 3, 2025
Merged

fix: lake: use -O0 for debug builds #11062

tydeu merged 3 commits into from
Nov 3, 2025

Conversation

@tydeu
Copy link
Member

@tydeu tydeu commented Nov 2, 2025

This PR changes Lake's debug build type to use -O0 instead of -Og when compiling C code. -Og was found to be insufficient for debugging compiled Lean code -- relevant code was stilled optimized out.

@tydeu tydeu added the changelog-lake Lake label Nov 2, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 2, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Nov 2, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-31 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-11-02 22:13:56)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 2, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11062
0f350e5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Nov 2, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11062
bef234b
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 2, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 2, 2025 •
edited
Loading

Mathlib CI status (docs):

@tydeu tydeu marked this pull request as ready for review November 3, 2025 01:15
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11062
d672306
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Nov 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11062
286ac4d
@tydeu tydeu added this pull request to the merge queue Nov 3, 2025
Merged via the queue into leanprover:master with commit 1aca181 Nov 3, 2025
17 checks passed
@tydeu tydeu deleted the lake/debug-O0 branch November 3, 2025 02:42
@leanprover-community-bot leanprover-community-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan and removed builds-mathlib CI has verified that Mathlib builds against this PR labels Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tydeu @leanprover-bot @leanprover-community-bot