Skip to content

Conversation

@Kha
Copy link
Member

@Kha Kha commented Nov 13, 2025

This PR ensures that the code action provided on unknown identifiers correctly inserts public and/or meta in modules

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 13, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Nov 13, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-11-12 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-11-13 17:49:50)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase f7ed15800246e6532d0fd01c5856f59a9bf9679f --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-11-20 17:48:41)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 13, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Nov 13, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 13, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 13, 2025

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-11164 has successfully built against this PR. (2025-11-13 19:11:02) View Log
  • ✅ Mathlib branch lean-pr-testing-11164 has successfully built against this PR. (2025-11-19 18:07:03) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f7ed15800246e6532d0fd01c5856f59a9bf9679f --onto a106ea053fec080a50204b0ad6dadc69bc3f0937. You can force Mathlib CI using the force-mathlib-ci label. (2025-11-20 17:48:40)

@Kha Kha marked this pull request as ready for review November 14, 2025 09:45
@Kha Kha requested review from digama0 and mhuisi as code owners November 14, 2025 09:45
@Kha
Copy link
Member Author

Kha commented Nov 14, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Nov 14, 2025

Benchmark results for 2074dca against d464b13 are in! @Kha

Major changes (12)
  • Init.Data.BitVec.Lemmas//instructions changed by +58.3% (🟥).
  • Init.Data.List.Sublist async//instructions changed by +87.3% (🟥).
  • Init.Prelude async//instructions changed by +535.3% (🟥).
  • Std.Data.DHashMap.Internal.RawLemmas//instructions changed by +69.0% (🟥).
  • Std.Data.Internal.List.Associative//instructions changed by +400.1% (🟥).
  • big_beq//instructions changed by +1.1% (🟥).
  • grind_bitvec2.lean//instructions changed by +25.5% (🟥).
  • grind_list2.lean//instructions changed by +19.1% (🟥).
  • identifier auto-completion//instructions changed by +1.9% (🟥).
  • mut_rec_wf//instructions changed by +8.5% (🟥).
  • riscv-ast.lean//instructions changed by +152.8% (🟥).
  • stdlib//instructions changed by +60.9% (🟥).
Minor changes (2)
  • big_beq_rec//instructions changed by +0.6% (🟥).
  • iterators (elab)//instructions changed by +0.8% (🟥).

@Kha
Copy link
Member Author

Kha commented Nov 14, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Nov 14, 2025

Benchmark results for 30dc746 against d464b13 are in! @Kha

Major changes (1)
  • identifier auto-completion//instructions changed by -5.1% (✅).

@Kha Kha added the changelog-server Language server, widgets, and IDE extensions label Nov 14, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 19, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Nov 19, 2025
@mhuisi
Copy link
Contributor

mhuisi commented Nov 20, 2025

!radar

@leanprover-radar
Copy link

leanprover-radar commented Nov 20, 2025

Benchmark results for e8b0217 against d464b13 are in! @mhuisi

Major changes (2)
  • identifier auto-completion//instructions changed by +2.2% (🟥).
  • stdlib//instructions changed by +7.5% (🟥).
Minor changes (1)
  • Init.Prelude async//instructions changed by +0.5% (🟥).

@Kha Kha force-pushed the push-xsqmylxqwwum branch from e8b0217 to 656587e Compare November 20, 2025 12:23
@Kha
Copy link
Member Author

Kha commented Nov 20, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Nov 20, 2025

Benchmark results for 656587e against fc6e045 are in! @Kha

Runs (2)
  • other exited with code 2 (🟥)
  • stdlib exited with code 2 (🟥)

@Kha Kha force-pushed the push-xsqmylxqwwum branch from 656587e to d1c1854 Compare November 20, 2025 15:36
@Kha
Copy link
Member Author

Kha commented Nov 20, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Nov 20, 2025

Benchmark results for abdbc4c against f7ed158 are in! @Kha

Major changes (2)
  • identifier auto-completion//instructions changed by +2.2% (🟥).
  • size/stdlib/.ilean//bytes changed by +8.9% (🟥).
Minor changes (2)
  • Init.Prelude async//instructions changed by +0.5% (🟥).
  • stdlib//instructions changed by +0.2% (🟥).


public section

#check Lean.Server.Test.Refs.Test1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this test case change intentionally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

if mod == q.ctx.env.mainModule then
continue
let insertion := q.determineInsertion decl
if ! imports.contains mod then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this logic need to be adjusted here, depending on the modifiers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could upgrade an existing import to public instead of inserting it but at that point we're encroaching a bit upon Shake territory

@Kha Kha force-pushed the push-xsqmylxqwwum branch from 9239132 to db0bee7 Compare December 12, 2025 21:05
@Kha Kha enabled auto-merge December 12, 2025 21:06
@Kha Kha added this pull request to the merge queue Dec 12, 2025
Merged via the queue into leanprover:master with commit de388a7 Dec 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants