-
Notifications
You must be signed in to change notification settings - Fork 717
feat: unknown identifier code action and the module system #11164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reference manual CI status:
|
|
Mathlib CI status (docs):
|
|
!bench |
|
Benchmark results for 2074dca against d464b13 are in! @Kha Major changes (12)
Minor changes (2)
|
|
!bench |
|
Benchmark results for 30dc746 against d464b13 are in! @Kha Major changes (1)
|
|
!radar |
|
Benchmark results for e8b0217 against d464b13 are in! @mhuisi Major changes (2)
Minor changes (1)
|
e8b0217 to
656587e
Compare
|
!bench |
|
Benchmark results for 656587e against fc6e045 are in! @Kha Runs (2)
|
656587e to
d1c1854
Compare
|
!bench |
|
Benchmark results for abdbc4c against f7ed158 are in! @Kha Major changes (2)
Minor changes (2)
|
|
|
||
| public section | ||
|
|
||
| #check Lean.Server.Test.Refs.Test1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this test case change intentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
| if mod == q.ctx.env.mainModule then | ||
| continue | ||
| let insertion := q.determineInsertion decl | ||
| if ! imports.contains mod then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this logic need to be adjusted here, depending on the modifiers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could upgrade an existing import to public instead of inserting it but at that point we're encroaching a bit upon Shake territory
9239132 to
db0bee7
Compare
This PR ensures that the code action provided on unknown identifiers correctly inserts
publicand/ormetainmodules