perf: parallelize exact? and apply? tactics
#11369
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
kim-em
force-pushed
the
parallel-library-search
branch
from
d2be87c to
53ec504
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 26, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Nov 26, 2025
Collaborator
Author
|
It's not clear this is a win. The overhead of parallelisation could easily exceed the gains. Measurements (perhaps with chunking?) are probably warranted. |
leanprover-community-bot
added
the
builds-mathlib
This PR adds optional chunking support to the `par` and `par'` functions in `Lean.Elab.Parallel` for CoreM, MetaM, TermElabM, and TacticM. This reduces task creation overhead when there are many small jobs by grouping them into chunks that run sequentially within each parallel task. New optional parameters: - `maxTasks : Nat := 0` - Maximum number of parallel tasks (0 = no limit) - `minChunkSize : Nat := 1` - Minimum jobs per chunk Example: With 1000 jobs and `maxTasks := 128, minChunkSize := 8`: - Chunk size = max(8, ceil(1000/128)) = 8 - Creates ~125 parallel tasks instead of 1000 Default behavior (maxTasks = 0) is unchanged - one task per job. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add `parIterWithCancelChunked` functions for CoreM, MetaM, TermElabM, and TacticM that support chunking jobs into groups to reduce task creation overhead. The original `parIterWithCancel` functions remain unchanged for backward compatibility. The new chunked variants accept `maxTasks` and `minChunkSize` parameters to control parallelism. This enables PRs that use `parIterWithCancel` (like parallel library search and rewrites) to benefit from chunking by switching to the new `parIterWithCancelChunked` function with `maxTasks := 128`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Use `MetaM.parIterWithCancel` to try all candidate lemmas in parallel while preserving deterministic result ordering. When a complete solution is found, remaining tasks are cancelled and the result is returned immediately. This removes the old sequential `tryOnEach` implementation along with the heartbeat-based abortion mechanism (`abortSpeculation`, `mkHeartbeatCheck`). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
kim-em
force-pushed
the
parallel-library-search
branch
2 times, most recently
from
f012657 to
4713811
Compare
kim-em
force-pushed
the
parallel-library-search
branch
from
5563a75 to
4713811
Compare
kim-em
added
changelog-tactics
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 2, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 2, 2025
leanprover-community-bot
added
the
builds-mathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parallelizes
exact?andapply?.MetaM.parIterWithCancelto try all candidate lemmas in parallel while preserving deterministic result orderingtryOnEachimplementation and heartbeat-based abortion mechanism🤖 Generated with Claude Code