Skip to content

feat: add seek and tell to FS.Handle #11442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lancelet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add seek and tell to FS.Handle #11442

lancelet wants to merge 1 commit into from
+232 −0

Conversation

@lancelet
Copy link

@lancelet lancelet commented Dec 1, 2025

This PR adds IO.FS.Handle.seek and IO.FS.Handle.tell functions, to allow positioning the file cursor and querying its location respectively.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 1, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-01 13:07:32)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11442
d618519
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11442
e66d1c0
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 1, 2025 •
edited
Loading

Mathlib CI status (docs):

@lancelet
feat: add seek and tell to FS.Handle
8e83d60 
This PR adds `IO.FS.Handle.seek` and `IO.FS.Handle.tell` functions,
to allow positioning the file cursor and querying its location
respectively.
@lancelet
Copy link
Author

lancelet commented Dec 2, 2025 •
edited
Loading

I think this PR is ready for review. Feedback is very welcome! It contains some Windows-specific code, so an MS Windows CI build would be good.

I'm hoping seek and tell can be included in Lean itself, but I didn't ask before raising this PR, so feel free to decline if there's a reason not to include them.

Unfortunately, I don't seem to have permissions to set a changelog-* label (probably the changelog-library label?).

@lancelet lancelet marked this pull request as ready for review December 2, 2025 09:45
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 2, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11442
8f4bf27
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 2, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11442
f0a4616
@tydeu tydeu added changelog-library Library release-ci Enable all CI checks for a PR, like is done for releases labels Dec 3, 2025
@tydeu tydeu requested a review from TwoFX December 3, 2025 15:44
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11442
e3b0385
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 3, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11442
896dcfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX Awaiting requested review from TwoFX

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lancelet @leanprover-bot @leanprover-community-bot @tydeu