Skip to content

Conversation

@hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Dec 1, 2025

This PR adapts the lambda lifter in LCNF to eta contract instead of lambda lift if possible. This prevents the creation of a few hundred unnecessary lambdas across the code base.

@hargoniX
Copy link
Contributor Author

hargoniX commented Dec 1, 2025

!radar

@leanprover-radar
Copy link

leanprover-radar commented Dec 1, 2025

Benchmark results for 7671691 against 5e165e3 are in! @hargoniX

Runs (2)
  • 🟥 build exited with code 2
  • 🟥 other exited with code 1

@hargoniX hargoniX force-pushed the hbv/less_lambda_lifting branch from 7671691 to bbebdb7 Compare December 1, 2025 18:42
@hargoniX hargoniX force-pushed the hbv/less_lambda_lifting branch from bbebdb7 to 05654e8 Compare December 1, 2025 18:43
@hargoniX
Copy link
Contributor Author

hargoniX commented Dec 1, 2025

!radar

@leanprover-radar
Copy link

leanprover-radar commented Dec 1, 2025

Benchmark results for 05654e8 against 310abce are in! @hargoniX

Minor changes (1)
  • channel.lean//instructions: -290.6M (-0.7%)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 1, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 310abce62b40e4b876f797c4aef7e29d483feb42 --onto 5bd331e85d9d110a29fb3367dbb21854010ffcbd. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-01 19:41:25)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 310abce62b40e4b876f797c4aef7e29d483feb42 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-01 19:41:27)

@hargoniX hargoniX added the changelog-language Language features and metaprograms label Dec 2, 2025
@hargoniX hargoniX marked this pull request as ready for review December 2, 2025 08:26
@hargoniX hargoniX requested a review from leodemoura as a code owner December 2, 2025 08:26
@hargoniX hargoniX enabled auto-merge December 2, 2025 08:27
@hargoniX hargoniX added changelog-compiler Compiler, runtime, and FFI and removed changelog-language Language features and metaprograms labels Dec 2, 2025
@hargoniX hargoniX added this pull request to the merge queue Dec 2, 2025
Merged via the queue into master with commit 3dd99fc Dec 2, 2025
32 checks passed
@hargoniX hargoniX deleted the hbv/less_lambda_lifting branch December 2, 2025 09:50
algebraic-dev pushed a commit that referenced this pull request Dec 8, 2025
This PR adapts the lambda lifter in LCNF to eta contract instead of
lambda lift if possible. This prevents the creation of a few hundred
unnecessary lambdas across the code base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants