Skip to content

feat: add mem_of_get_eq and of_getElem_eq #11452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wkrozowski merged 5 commits into from
Dec 2, 2025
Merged

feat: add mem_of_get_eq and of_getElem_eq #11452

wkrozowski merged 5 commits into from
Dec 2, 2025

Conversation

@wkrozowski
Copy link
Contributor

@wkrozowski wkrozowski commented Dec 1, 2025

This PR adds lemmas stating that if a get operation returns a value, then the queried key must be contained in the collection. These lemmas are added for HashMap and TreeMap-based collections, with a similar lemma also added for Init.getElem.

@wkrozowski wkrozowski requested a review from TwoFX as a code owner December 1, 2025 16:51
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 1, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1ae680c5e2f3922ba0c6c257a105426fdab20999 --onto 5bd331e85d9d110a29fb3367dbb21854010ffcbd. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-01 18:09:03)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 1ae680c5e2f3922ba0c6c257a105426fdab20999 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-01 18:09:04)

TwoFX
TwoFX reviewed Dec 2, 2025
View reviewed changes
@wkrozowski
Copy link
Contributor Author

wkrozowski commented Dec 2, 2025

@TwoFX Okay, I have resolved your round of comments

@wkrozowski wkrozowski added this pull request to the merge queue Dec 2, 2025
Merged via the queue into leanprover:master with commit 8b7cbe7 Dec 2, 2025
16 checks passed
algebraic-dev pushed a commit that referenced this pull request Dec 8, 2025
@wkrozowski @algebraic-dev
feat: add mem_of_get_eq and of_getElem_eq (#11452)
7375503 
This PR adds lemmas stating that if a get operation returns a value,
then the queried key must be contained in the collection. These lemmas
are added for HashMap and TreeMap-based collections, with a similar
lemma also added for `Init.getElem`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees

No one assigned

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wkrozowski @leanprover-community-bot @leanprover-bot @TwoFX