Skip to content

fix: call delete [] on array allocations #11453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kha merged 1 commit into from
Dec 10, 2025
Merged

fix: call delete [] on array allocations #11453

Kha merged 1 commit into from
Dec 10, 2025

Conversation

@eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Dec 1, 2025 •
edited
Loading

This PR fixes undefined behavior where delete (instead of delete[]) is called on an object allocated with new[].

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 1, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 1, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 310abce62b40e4b876f797c4aef7e29d483feb42 --onto 5bd331e85d9d110a29fb3367dbb21854010ffcbd. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-01 21:01:00)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 1, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 310abce62b40e4b876f797c4aef7e29d483feb42 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-01 21:01:02)

@eric-wieser
Copy link
Contributor Author

eric-wieser commented Dec 2, 2025

changelog-language

@github-actions github-actions bot added the changelog-language Language features and metaprograms label Dec 2, 2025
@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Dec 10, 2025
@Kha Kha enabled auto-merge December 10, 2025 10:29
@eric-wieser
Copy link
Contributor Author

eric-wieser commented Dec 10, 2025

@Kha, could you re-run CI? Looks like something unrelated and flaky caught this.

@Kha Kha removed the release-ci Enable all CI checks for a PR, like is done for releases label Dec 10, 2025
@Kha Kha added this pull request to the merge queue Dec 10, 2025
Merged via the queue into leanprover:master with commit 1824865 Dec 10, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eric-wieser @leanprover-community-bot @leanprover-bot @Kha