Skip to content

doc: add missing docstrings for Rxy.Sliceable #11472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
david-christiansen merged 1 commit into from
Dec 2, 2025
Merged

doc: add missing docstrings for Rxy.Sliceable #11472

david-christiansen merged 1 commit into from
Dec 2, 2025

Conversation

@david-christiansen
Copy link
Contributor

@david-christiansen david-christiansen commented Dec 2, 2025

This PR adds missing docstrings for the mkSlice methods.

@david-christiansen
doc: add missing docstrings for Rxy.Sliceable
998e25b 
This PR adds missing docstrings for the `mkSlice` methods.
@david-christiansen david-christiansen added the changelog-doc Documentation label Dec 2, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 2, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 2, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 226a90f1ebbb14ace0d3f416e511847e84311546 --onto 5bd331e85d9d110a29fb3367dbb21854010ffcbd. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-02 08:30:52)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 2, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 226a90f1ebbb14ace0d3f416e511847e84311546 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-02 08:30:54)

datokrat
datokrat approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@datokrat datokrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-christiansen david-christiansen added this pull request to the merge queue Dec 2, 2025
@david-christiansen
Copy link
Contributor Author

david-christiansen commented Dec 2, 2025

Thanks for a quick look and approval!

Merged via the queue into leanprover:master with commit 0e83422 Dec 2, 2025
21 checks passed
algebraic-dev pushed a commit that referenced this pull request Dec 8, 2025
@david-christiansen @algebraic-dev
doc: add missing docstrings for Rxy.Sliceable (#11472)
9052b93 
This PR adds missing docstrings for the `mkSlice` methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datokrat datokrat datokrat approved these changes

Assignees

No one assigned

Labels

changelog-doc Documentation toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@david-christiansen @leanprover-community-bot @leanprover-bot @datokrat