fix: Char -> Bool as default instance for string search
#11503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algebraic-dev
pushed a commit
that referenced
this pull request
Dec 8, 2025
This PR marks `Char -> Bool` patterns as default instances for string search. This means that things like `" ".find (·.isWhitespace)` can now be elaborated without error. Previously, it was necessary to write `" ".find Char.isWhitespace`. Thank you to David Christiansen for the idea of using a default instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks
Char -> Boolpatterns as default instances for string search. This means that things like" ".find (·.isWhitespace)can now be elaborated without error.Previously, it was necessary to write
" ".find Char.isWhitespace.Thank you to David Christiansen for the idea of using a default instance.