perf: make more SizeOf instances noncomputable #11505
Closed
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes more `SizeOf` instances noncomputable, for consistency with the derived instances. See https://leanprover.zulipchat.com/#narrow/channel/113489-new-members/topic/Compiler.20error.20with.20sizeOf/with/561525387 for the kind of confusion this PR tries to avoid.
nomeata
force-pushed
the
joachim/noncomputable-sizeof
branch
from
0f877d4 to
4f22033
Compare
nomeata
added
the
awaiting-mathlib
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Dec 4, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Dec 4, 2025
leanprover-community-bot
added
the
breaks-mathlib
Collaborator
|
Collaborator
Author
|
This breaks mathlib in uses of Mathlib.Util.CompileInductive. Not going to investigate for now. |
auto-merge was automatically disabled
December 4, 2025 12:19
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes more
SizeOfinstances noncomputable, for consistency with the derived instances.See https://leanprover.zulipchat.com/#narrow/channel/113489-new-members/topic/Compiler.20error.20with.20sizeOf/with/561525387 for the kind of confusion this PR tries to avoid.