Skip to content

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Dec 4, 2025

This PR avoids running substCore twice in caseValues.

@nomeata nomeata added the changelog-language Language features and metaprograms label Dec 4, 2025
@nomeata
Copy link
Collaborator Author

nomeata commented Dec 4, 2025

!radar

@leanprover-radar
Copy link

leanprover-radar commented Dec 4, 2025

Benchmark results for 3ee6542 against e548fa4 are in! @nomeata

Major changes (2)
  • big_match_nat//instructions: -40.3G (-56.9%)
  • big_match_nat_split//instructions: -17.5G (-51.6%)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 4, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e548fa414cb74db21a31afe6c26cb0c51310f1db --onto 0173444d24df9253d7947cfe82519e4a6caffd3a. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-04 11:27:06)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase e548fa414cb74db21a31afe6c26cb0c51310f1db --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-04 11:27:08)

This PR avoids running `substCore` twice in `caseValues`.
@nomeata nomeata force-pushed the joachim/caseValues-subst-once branch from 3ee6542 to ca4cb0c Compare December 4, 2025 11:53
@nomeata nomeata added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Dec 4, 2025
@nomeata nomeata marked this pull request as ready for review December 4, 2025 11:54
@nomeata nomeata enabled auto-merge December 4, 2025 11:55
@nomeata
Copy link
Collaborator Author

nomeata commented Dec 4, 2025

Very nice radar results. I wonder if they add to those of #11508. But probably they are a subset of those.

@nomeata nomeata changed the base branch from master to nightly-with-mathlib December 4, 2025 12:53
@nomeata nomeata merged commit 5ded87c into nightly-with-mathlib Dec 4, 2025
2 checks passed
@nomeata
Copy link
Collaborator Author

nomeata commented Dec 4, 2025

!radar

@leanprover-radar
Copy link

leanprover-radar commented Dec 4, 2025

Benchmark results for 98a06ec against 0173444 are in! @nomeata

@nomeata
Copy link
Collaborator Author

nomeata commented Dec 4, 2025

Sorry for the accidential merge into nightly-with-mathlib. I blame Github for refusing to run CI just because there is a conflict with master. Second try at #11510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-mathlib We should not merge this until we have a successful Mathlib build changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants