-
Notifications
You must be signed in to change notification settings - Fork 715
perf: in CaseValues, subst only once #11506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!radar |
|
Benchmark results for 3ee6542 against e548fa4 are in! @nomeata Major changes (2)
|
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
This PR avoids running `substCore` twice in `caseValues`.
3ee6542 to
ca4cb0c
Compare
|
Very nice radar results. I wonder if they add to those of #11508. But probably they are a subset of those. |
|
!radar |
|
Benchmark results for 98a06ec against 0173444 are in! @nomeata |
|
Sorry for the accidential merge into nightly-with-mathlib. I blame Github for refusing to run CI just because there is a conflict with master. Second try at #11510 |
This PR avoids running
substCoretwice incaseValues.