Skip to content

Conversation

@Kha
Copy link
Member

@Kha Kha commented Dec 4, 2025

This PR optimizes the filesystem accesses during importing for a ~3% win on Linux, potentially more on other platforms.

@Kha
Copy link
Member Author

Kha commented Dec 4, 2025

!bench

@leanprover-radar

This comment was marked as outdated.

@Kha
Copy link
Member Author

Kha commented Dec 4, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Dec 4, 2025

Benchmark results for bd1339d against 0173444 are in! @Kha

Major changes (13)
  • big_beq//instructions: -138.4M (-1.2%)
  • big_deceq//instructions: -139.2M (-2.6%)
  • big_deceq_rec//instructions: -141.3M (-1.9%)
  • big_match//instructions: -141.4M (-1.1%)
  • import Lean//instructions: -112.3M (-5.7%)
  • iterators (elab)//instructions: -42.1M (-1.1%)
  • lake build clean//instructions: -84.1G (-3.8%)
  • lake build no-op//instructions: -76.9M (-1.2%)
  • lake config elab//instructions: -82.1M (-2.6%)
  • lake config import//instructions: -89.6M (-5.7%)
  • lake config tree//instructions: -79.4M (-4.9%)
  • lake env//instructions: -81.6M (-5.1%)
  • simp_arith1//instructions: -62.0M (-1.9%)
Minor changes (5)
  • big_beq_rec//instructions: -138.2M (-0.6%)
  • big_match_partial//instructions: -135.2M (-0.8%)
  • build//instructions: -18.3G (-0.1%)
  • omega_stress.lean async//instructions: -37.9M (-0.7%)
  • reduceMatch//instructions: -132.2M (-0.7%)

@Kha Kha added the release-ci Enable all CI checks for a PR, like is done for releases label Dec 4, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 4, 2025
@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-03 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-04 13:59:59)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 4, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 4, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 4, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 4, 2025

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 4, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 4, 2025
@Kha Kha marked this pull request as ready for review December 5, 2025 09:37
@Kha Kha enabled auto-merge December 5, 2025 09:37
@Kha Kha added this pull request to the merge queue Dec 5, 2025
Merged via the queue into leanprover:master with commit 76f32e2 Dec 5, 2025
31 checks passed
algebraic-dev pushed a commit that referenced this pull request Dec 8, 2025
This PR optimizes the filesystem accesses during importing for a ~3% win
on Linux, potentially more on other platforms.
@Kha Kha deleted the push-tmqvuvuxqlsr branch December 9, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-other release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants