Skip to content

chore: measure dynamic symbols in benchmarks #11568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Garmelon merged 2 commits into from
Dec 11, 2025
Merged

chore: measure dynamic symbols in benchmarks #11568

Garmelon merged 2 commits into from
Dec 11, 2025

Conversation

@Garmelon
Copy link
Contributor

@Garmelon Garmelon commented Dec 9, 2025

Add back the dynamic symbol measurements that were removed in #11264.

@Garmelon
Copy link
Contributor Author

Garmelon commented Dec 9, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Dec 9, 2025 •
edited
Loading

Benchmark results for 06f1e48 against 5326530 are in! @Garmelon

No significant changes detected.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 9, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 9, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5326530383a4d0c65d4a8b008ae2327c491b25be --onto 1d0d3915ca79d0875a757fc5061121ae9cd58543. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-09 19:04:38)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 9, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 5326530383a4d0c65d4a8b008ae2327c491b25be --onto 62f2f9229356039356c0469a46d8ecd77be88e2a. You can force reference manual CI using the force-manual-ci label. (2025-12-09 19:04:40)

@Garmelon
Copy link
Contributor Author

Garmelon commented Dec 11, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Dec 11, 2025 •
edited
Loading

Benchmark results for acceb54 against 5326530 are in! @Garmelon

No significant changes detected.

@Garmelon Garmelon added this pull request to the merge queue Dec 11, 2025
Merged via the queue into master with commit cec9758 Dec 11, 2025
13 of 14 checks passed
@Garmelon Garmelon deleted the joscha/count-symbols-again branch December 11, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Garmelon @leanprover-radar @leanprover-community-bot @leanprover-bot