Skip to content

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Dec 9, 2025

This PR lets whnf not consult isNoConfusion, to speed up this hot path a bit.

@nomeata nomeata added the changelog-language Language features and metaprograms label Dec 9, 2025
@nomeata
Copy link
Collaborator Author

nomeata commented Dec 9, 2025

!radar

@leanprover-radar
Copy link

leanprover-radar commented Dec 9, 2025

Benchmark results for 11a3329 against 1d0d391 are in! @nomeata

Major changes (2)
  • build//instructions: -50.2G (-0.4%)
  • bv_decide_rewriter.lean//instructions: -350.2M (-1.8%)
Minor changes (5)
  • Init.Data.BitVec.Lemmas re-elab//instructions: -6.2G (-0.7%)
  • Init.Data.BitVec.Lemmas//instructions: -1.2G (-0.8%)
  • grind_bitvec2.lean//instructions: -1.7G (-0.8%)
  • grind_list2.lean//instructions: -403.6M (-0.6%)
  • riscv-ast.lean//instructions: -730.6M (-0.5%)

@nomeata nomeata changed the base branch from master to nightly December 9, 2025 22:01
@nomeata nomeata marked this pull request as ready for review December 9, 2025 23:22
@nomeata nomeata changed the base branch from nightly to master December 9, 2025 23:22
@nomeata nomeata enabled auto-merge December 9, 2025 23:23
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 9, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 9, 2025
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Dec 9, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 9, 2025
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Dec 9, 2025
@nomeata nomeata added this pull request to the merge queue Dec 9, 2025
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Dec 9, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 9, 2025

Reference manual CI status:

Merged via the queue into master with commit 19e1fe5 Dec 9, 2025
19 checks passed
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 10, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@Kha
Copy link
Member

Kha commented Dec 10, 2025

!bench mathlib

(my first try using it)

@leanprover-radar
Copy link

leanprover-radar commented Dec 10, 2025

Benchmark results for leanprover-community/mathlib4-nightly-testing@2ee6d2d against leanprover-community/mathlib4-nightly-testing@bbf1f53 are in! @Kha

Minor changes (2)
  • build/module/Mathlib.RingTheory.DedekindDomain.Different//instructions: -6.2G (-1.6%)
  • build/module/Mathlib.RingTheory.Polynomial.UniversalFactorizationRing//instructions: -6.3G (-1.7%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants