feat: add grind attribute to Nat.cast_id and Int.cast_id #11572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
added
changelog-libeary
changelog-library
kim-em
force-pushed
the
grind_cast_id
branch
from
2143f85 to
0a325a7
Compare
Adds `Nat.cast_id` to `Init/Data/Nat/Lemmas.lean` with `simp`, `norm_cast`, and `grind =` attributes. Also adds `grind =` to the existing `Int.cast_id`. 🤖 Prepared with Claude Code Co-Authored-By: Claude <[email protected]>
kim-em
force-pushed
the
grind_cast_id
branch
from
0a325a7 to
fc1e7a2
Compare
Collaborator
Author
|
No, these are bad annotations, they would trigger everywhere. Back to the drawing board. |
auto-merge was automatically disabled
December 10, 2025 03:37
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Nat.cast_id(upstream from mathlib) and adds thegrind =attribute to bothNat.cast_idand the existingInt.cast_id.🤖 Prepared with Claude Code